Add 2FA support #82
Open
Add 2FA support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In re #47 , I have implement 2FA support by adding new Flag named
mfaormfor short. It is boolean type, indicating either default profile or named profile provided viaprofileflag has MFA enabled.Implementation sets Session Options field
AssumeRoleTokenProviderwithstscreds.StdinTokenProviderand also set duration for this session as 1 hour, the duration can be provided via user input withdurationflag but for now it is hard coded. I can change that if needed.Note: 2FA will only work here for IAM Role that have 2FA enabled.