Update Transpiler string method to respect AST quoteStyle option for AstExprConstantString #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegorov-rbx
reviewed
Nov 27, 2023
| @@ -49,7 +49,7 @@ struct Writer | |||
| virtual void keyword(std::string_view) = 0; | |||
| virtual void symbol(std::string_view) = 0; | |||
| virtual void literal(std::string_view) = 0; | |||
| virtual void string(std::string_view) = 0; | |||
| virtual void string(std::string_view, bool quoted = true) = 0; | |||
There was a problem hiding this comment.
It would be better to avoid default argument values and update the second call to string instead (there are only 2 calls).
|
This PR is missing tests (in Transpiler.test.cpp). It's not obvious what code was even transpiled incorrectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AstExprConstantString's
quoteStylefield was disregarded during the process of transpiling, this change fixes that and keeps original behavior for all other calls towriter.string.