Remove unsupported load-icons-ignoring-image-load setting

Deprecated since 2.42, now unsupported (ignored)
luakit · Feb 10, 2024 · 2f633b3 · 2f633b3
1 parent 100e060
commit 2f633b3
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ### Changed
 
 - Don't compress man page. This should be done by maintainers.
+- Removed now unsupported/ignored load-icons-ignoring-image-load-setting.
 
 ### Fixed
 

diff --git a/common/tokenize.list b/common/tokenize.list
@@ -193,7 +193,6 @@ enable_tabs_to_links
 enable_webaudio
 enable_webgl
 enable_write_console_messages_to_stdout
-load_icons_ignoring_image_load_setting
 media_playback_allows_inline
 media_playback_requires_gesture
 pictograph_font_family

diff --git a/lib/domain_props.lua b/lib/domain_props.lua
@@ -85,7 +85,6 @@
 --  - `fantasy_font_family`
 --  - `javascript_can_access_clipboard`
 --  - `javascript_can_open_windows_automatically`
---  - `load_icons_ignoring_image_load_setting`
 --  - `media_playback_allows_inline`
 --  - `media_playback_requires_user_gesture`
 --  - `minimum_font_size`

diff --git a/lib/webview.lua b/lib/webview.lua
@@ -660,11 +660,6 @@ local webview_settings = {
         default = false,
         desc = "Whether JavaScript can open windows without user intervention.",
     },
-    ["webview.load_icons_ignoring_image_load_setting"] = {
-        type = "boolean",
-        default = false,
-        desc = "Whether web page favicons should be loaded, even if `webview.auto_load_images` is disabled.",
-    },
     ["webview.media_playback_allows_inline"] = {
         type = "boolean",
         default = true,

diff --git a/widgets/webview.c b/widgets/webview.c
@@ -134,7 +134,6 @@ static property_t webview_settings_properties[] = {
   { L_TK_FANTASY_FONT_FAMILY,                       "fantasy-font-family",                       CHAR,  TRUE },
   { L_TK_JAVASCRIPT_CAN_ACCESS_CLIPBOARD,           "javascript-can-access-clipboard",           BOOL,  TRUE },
   { L_TK_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY, "javascript-can-open-windows-automatically", BOOL,  TRUE },
-  { L_TK_LOAD_ICONS_IGNORING_IMAGE_LOAD_SETTING,    "load-icons-ignoring-image-load-setting",    BOOL,  TRUE },
   { L_TK_MEDIA_PLAYBACK_ALLOWS_INLINE,              "media-playback-allows-inline",              BOOL,  TRUE },
   { L_TK_MEDIA_PLAYBACK_REQUIRES_GESTURE,           "media-playback-requires-user-gesture",      BOOL,  TRUE },
   { L_TK_MINIMUM_FONT_SIZE,                         "minimum-font-size",                         INT,   TRUE },