retryhandler处理repeat job的bug-卢松 #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
假如job repeatCount为5，重试次数设置为5次，那么前面4次repeat都会比较retry的时间和下次repeat job的时间. 而最后一次repeat job会把重试次数5次用完。具体看注释。 原来的逻辑会导致job永远不会结束执行，因为repeatedCount一直没有变，永远不能时repeatCount变为5，循环执行下去！
lusong1986
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
假如job repeatCount为5，重试次数设置为5次，那么前面4次repeat都会比较retry的时间和下次repeat job的时间.
而最后一次repeat job会把重试次数5次用完。具体看注释。
原来的逻辑会导致job永远不会结束执行，因为repeatedCount一直没有变，永远不能时repeatCount变为5，循环执行下去！