DM-43319: Fix warnings #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkeijuro
force-pushed
the
tickets/DM-43319
branch
from
468ad6a
to
241db9e
Compare
mfisherlevine
commented
May 14, 2024
tests/test_focusAnalysis.py
Outdated
| # to avoid getting the next Warning: | ||
| # UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown | ||
| # plt.show() | ||
| plt.show = custom_show |
There was a problem hiding this comment.
I wonder if the right solution isn't just to remove the calls to plt.show() to be honest, I doubt that's ever actually used interactively.
There was a problem hiding this comment.
So we should remove the show inside the code? The show() is not part from the test but from the function in the library. I guess you mean returning the matplotlib Plot and then the uplayer call the show() from it, (but that is a big change)
There was a problem hiding this comment.
As I put on the other PR, yes, I think that's fine to remove, nobody will be using this interactively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.