-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/sitcom 1224 #130
base: develop
Are you sure you want to change the base?
Tickets/sitcom 1224 #130
Conversation
First version of plot_vel_charge function Add charge to plot_vel_charge function Include in plot_vel_charge function the current draw and the voltage
Add scatter and hist total discharge energy Change comments and variable names Add comments Copy last version SITCOM-1136
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
please clear outputs from the notebooks, and remove the M1M3 notebook (not associated with this ticket). |
…alysis_stability_tracking.ipynb Signed-off-by: Laura Toribio San Cipriano <144215139+ltoribiosc@users.noreply.github.com>
…citor_Bank_discharge_vs._Acceleration_profiles.ipynb Signed-off-by: Laura Toribio San Cipriano <144215139+ltoribiosc@users.noreply.github.com>
I have just deleted the M1M3 files. |
please clear outputs. check units in plots (should be angles). I didn't see where we calculate the Joules being discharged from the capacitor bank, only Coulombs which isn't exactly what we want/need. |
I am reviewing the code and (if I am not mistaken) the Joules that are discharged from the capacitor bank are calculated, but I got confused when making the graphs and I put Coulombs on the axis.
The work (in Joules) is calculated as the integral during the movement (slew) of the current multiplied by the voltage. What I call total energy.
energy_total = np.trapz(power_df.powerSupplyCurrent * power_df.powerSupplyVoltage)
I'm going to review it one more time and change the axes of the graphs. I'll let you know when it's ready so you can tell me if it's correct.
Thank you |
Brian, I still have to clean up the outputs but could you please check that it now shows what is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
large volume of plots generated as png files, especially the slew profiles. perhaps make an example set of plots for a single night (and single slew profile), and plot them in-line (and just explain how to generate for other nights).
…_vs_az and plot_energy_histogram function
I have commented in all functions the option to save the .png. Especially, in the analysis of the slews, I have added an option to save the figures as .png or not. I have left the option of being able to save them, because it can be interesting to study all of them in one night. I've also had some examples shown online. I have also added comments to know how to remove only the examples from being shown, save the .png or not and change the observation night |
No description provided.