Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 1282 #128

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Tickets/sitcom 1282 #128

wants to merge 15 commits into from

Conversation

nsevilla
Copy link
Collaborator

@nsevilla nsevilla commented Apr 9, 2024

This is a script to programatically create a BLOCK with pairs of stars for star tracker tests.

@ltoribiosc
Copy link
Contributor

This script selects star pairs for tracking testing taking in account the separation between stars, elevation and magnitud.

I have some doubts about the compute_pair_list function, especially in the for i,(refstar,refhd) loop...

What is refhd used for and what is its function? In the first part of the loop, until the if, it is not used for anything, but it confuses me that it is the first statement in the loop. I have the same comment for hd2

@ltoribiosc
Copy link
Contributor

In the same loop (for i,(refstar,refhd) in enumerate(stars_altaz_hd):), it calculates the value of az in two different ways, in addition to an alt_old that is not used at all. I'm not sure if this second az could be a bug or a part of the code that was not deleted

@nsevilla nsevilla requested a review from ltoribiosc May 23, 2024 14:08
@nsevilla
Copy link
Collaborator Author

In the same loop (for i,(refstar,refhd) in enumerate(stars_altaz_hd):), it calculates the value of az in two different ways, in addition to an alt_old that is not used at all. I'm not sure if this second az could be a bug or a part of the code that was not deleted

Fixed

@nsevilla
Copy link
Collaborator Author

This script selects star pairs for tracking testing taking in account the separation between stars, elevation and magnitud.

I have some doubts about the compute_pair_list function, especially in the for i,(refstar,refhd) loop...

What is refhd used for and what is its function? In the first part of the loop, until the if, it is not used for anything, but it confuses me that it is the first statement in the loop. I have the same comment for hd2

It is the HD denomination of the star (Henry Draper Catalog), needed to write the BLOCK. I download that information previously at

hd = table[selection_vmag]['HD']

and zip it with the rest of the star information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants