Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to query regulator #11

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rjcoelho
Copy link

Useful to report to a gauge stats.

@g-andrade
Copy link
Contributor

This won't work for counter regulators[1], I believe, since they're not ETS-based.

Assuming I'm right, perhaps counter-type queue processes could update the ETS table correspondingly every time they perform book keeping. This should make your current changes work for both rate and counter regulators. What do you think?

[1]: the ones that limit concurrency rather than rate

@g-andrade
Copy link
Contributor

The existing test cases could also be easily extended to check the value returned by your new function.

@rjcoelho
Copy link
Author

Ets update just for query ? I will have a look at counter implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants