Allow MIX_ENV/MIX_TARGET settings to pass through #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, `MIX_ENV=test` was forced and any `preferred_cli_env` and `preferred_cli_target` configuration in the `mix.exs` would look like it was ignored. In actuality, `preferred_cli_*` wasn't ignored, but you'd have to set it on `do` based on how ANSI color was enabled. This change enables ANSI a different way so that the mix target is passed through and can get the `preferred_cli_*` settings, if any. Because of this `MIX_ENV` doesn't need to be forced any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
MIX_ENV=testwas forced and anypreferred_cli_envandpreferred_cli_targetconfiguration in themix.exswould look like it was ignored. In actuality,preferred_cli_*wasn't ignored, but you'd have to set it ondobasedon how ANSI color was enabled.
This change enables ANSI a different way so that the mix target is
passed through and can get the
preferred_cli_*settings, if any.Because of this
MIX_ENVdoesn't need to be forced any more.