Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DirectEvent to BubblingEvent on Android/Windows #1222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sunbreak
Copy link
Contributor

fix #1221

@TheRogue76
Copy link
Collaborator

Hey @Sunbreak. Sorry we haven't reviewed your PR. I will allocate some free time this weekend, make sure the Android setup is working good for new arch and old arch and either give feedback or approve and merge it.

@TheRogue76
Copy link
Collaborator

@Sunbreak Checked on Android in Fabric, the events do not seem to be sent anymore:
Screenshot 2024-05-04 at 09 42 23

Copy link
Collaborator

@TheRogue76 TheRogue76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have been broken on Android

@Sunbreak
Copy link
Contributor Author

Sunbreak commented May 6, 2024

Or BubblingEvent to DirectEvent on iOS?

@TheRogue76
Copy link
Collaborator

Or BubblingEvent to DirectEvent on iOS?

Come to think of it, maybe it should all be direct events, even for iOS and in the spec. The point of Bubbling event was that we had some weird setup where the custom view of Lottie was wrapped by another view, but now that it is gone, maybe the spec should change and it should all become direct event, cause we are capturing it there directly. Try it out, let me know how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicts event type within Android/iOS/Windows
2 participants