Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup for rn-windows #1158

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Victor0814gui
Copy link

Description

I added only a few basic configurations so that the autolink in react-native-windows recognizes the library. I followed the recommendations from https://microsoft.github.io/react-native-windows/docs/native-modules-setup.

Steps To Reproduce

Follow these steps at https://microsoft.github.io/react-native-windows/docs/getting-started and create a React Native app. Then, run npx react-native autolink-windows. You'll notice that the file LottieReactNative.vsxproj is not present in the solutions list.

Expected Results

The LottieReactNative.vcxproj file should appear in the list of solutions.

@TheRogue76
Copy link
Collaborator

TheRogue76 commented Jan 13, 2024

Hmmm. I can't run anything locally right now, since I don't have a windows machine and i am a bit hesitant about touching anything in core. I'll run the CI to see if anything breaks with this in our current setup in the meantime and maybe we can update the examples to include windows so we can test these properly. @matinzd what do you think?

@Victor0814gui
Copy link
Author

Good question, I also hesitated to make any changes to the core in an inappropriate way. To keep this as transparent and clear as possible, I will add CI to see if anything breaks on Windows. I believe this is a critical bug, as without it, lottie-react-native 6.x.x doesn't work on Windows.

@TheRogue76
Copy link
Collaborator

@Victor0814gui
Copy link
Author

A basic summary of what I did in this last change: the dependency on react-native-windows in the example was at version 0.71.18 and has been updated to 0.72.24. Additionally, I modified the Example.sln file to use the correct paths for the node_modules folder, and updated the version of Microsoft.UI.Xaml from 2.6.0 to 2.8.0. Finally, concluding with the CI correction.

@TheRogue76
Copy link
Collaborator

A basic summary of what I did in this last change: the dependency on react-native-windows in the example was at version 0.71.18 and has been updated to 0.72.24. Additionally, I modified the Example.sln file to use the correct paths for the node_modules folder, and updated the version of Microsoft.UI.Xaml from 2.6.0 to 2.8.0. Finally, concluding with the CI correction.

Left one change that i think is important. The rest looks good. I'll let the CI run and once all the stuff is resolved, we can merge. One question though, mostly out of curiosity, does the linking for Example.sln need to be handled manually? Does RNW not have some sort of Auto linking for these?

@TheRogue76
Copy link
Collaborator

TheRogue76 commented Jan 15, 2024

The CI failed again. Looks like it is missing an SDK:
Screenshot 2024-01-15 at 18 58 24
@Victor0814gui

@Victor0814gui
Copy link
Author

I fixed the absence of the SDK and added an extra step to check which SDKs are installed👍.

Co-authored-by: Parsa Nasirimehr <40071952+TheRogue76@users.noreply.github.com>
@TheRogue76
Copy link
Collaborator

The Workflow file is being reported as invalid. I believe you have a typo on Line 33:
https://github.com/lottie-react-native/lottie-react-native/actions/runs/7533290462

@TheRogue76
Copy link
Collaborator

Hi.
Any progress / things we can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants