fix: check environment when doing pre-upgrade with Helm #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: longhorn#7571 Signed-off-by: James Lu <james.lu@suse.com>
derekbit
reviewed
May 2, 2024
Comment on lines
+23
to
+42
| securityContext: | ||
| privileged: true | ||
| command: | ||
| - longhorn-manager | ||
| - pre-upgrade | ||
| volumeMounts: | ||
| - name: proc | ||
| mountPath: /host/proc/ | ||
| env: | ||
| - name: POD_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
| - name: NODE_NAME | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: spec.nodeName | ||
| volumes: | ||
| - name: proc | ||
| hostPath: |
There was a problem hiding this comment.
Adding a description for the /proc and privileged: true in the commit message is appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # #7571
What this PR does / why we need it:
Check if the environment settings are achieved when doing pre-upgrade job with Helm, ref: environment_check.sh
Special notes for your reviewer:
Additional documentation or context