Feat(LEP): Longhorn toolbox CLI #8428
Conversation
c3y1huang
force-pushed
the
lep-feat-cli
branch
14 times, most recently
from
c53ebfc
to
e4ff3e6
Compare
c3y1huang
force-pushed
the
lep-feat-cli
branch
8 times, most recently
from
a4098ac
to
9763da4
Compare
c3y1huang
force-pushed
the
lep-feat-cli
branch
2 times, most recently
from
94c1fbe
to
e551883
Compare
There was a problem hiding this comment.
This is really in-depth and well-written. Thank you!
I have a few questions to discuss. Please find them in my review.
My major concern with implementing a CLI like this is that I want us to try to avoid duplicate effort wherever possible. (For example, if we can already get information easily with a kubectl command, we don't need a CLI command to do the same.) I was a bit worried when I first saw the get replica command, but I think it generally aims to retrieve additional information that we don't (and probably won't) put in the replica CRD. Overall, I think the LEP provides good examples of extra functionality that we can't achieve with it.
No real concerns from an implementation standpoint. It looks like we are using industry standard command line libraries, etc.
longhorn/longhorn-7927 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
|
cc @Vicente-Cheng @bk201 @WebberHuang1118 can check this from a support perspective |
Which issue(s) this PR fixes:
Issue #7927
What this PR does / why we need it:
This LEP introduces the Longhorn Toolbox CLI, laying the foundation for upcoming development. The CLI aims to streamline manual Longhorn operations like troubleshooting and non-custom-resource operations.
Special notes for your reviewer:
NoneAdditional documentation or context
None