Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crd: introduce the field applied in setting #8424

Merged
merged 1 commit into from
May 13, 2024
Merged

crd: introduce the field applied in setting #8424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ rules:
resources: ["volumesnapshotclasses", "volumesnapshots", "volumesnapshotcontents", "volumesnapshotcontents/status"]
verbs: ["*"]
- apiGroups: ["longhorn.io"]
resources: ["volumes", "volumes/status", "engines", "engines/status", "replicas", "replicas/status", "settings",
resources: ["volumes", "volumes/status", "engines", "engines/status", "replicas", "replicas/status", "settings", "settings/status",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if we need to update the uninstall.yaml. I thought we don't.

"engineimages", "engineimages/status", "nodes", "nodes/status", "instancemanagers", "instancemanagers/status",
{{- if .Values.openshift.enabled }}
"engineimages/finalizers", "nodes/finalizers", "instancemanagers/finalizers",
Expand Down
13 changes: 13 additions & 0 deletions chart/templates/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2835,6 +2835,10 @@ spec:
jsonPath: .value
name: Value
type: string
- description: The setting is applied
jsonPath: .status.applied
name: Applied
type: boolean
- jsonPath: .metadata.creationTimestamp
name: Age
type: date
Expand All @@ -2851,6 +2855,15 @@ spec:
type: string
metadata:
type: object
status:
description: SettingStatus defines the observed state of the Longhorn setting
properties:
applied:
description: The setting is applied.
type: boolean
required:
- applied
type: object
value:
description: The value of the setting.
type: string
Expand Down
15 changes: 14 additions & 1 deletion deploy/longhorn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2987,6 +2987,10 @@ spec:
jsonPath: .value
name: Value
type: string
- description: The setting is applied
jsonPath: .status.applied
name: Applied
type: boolean
- jsonPath: .metadata.creationTimestamp
name: Age
type: date
Expand All @@ -3003,6 +3007,15 @@ spec:
type: string
metadata:
type: object
status:
description: SettingStatus defines the observed state of the Longhorn setting
properties:
applied:
description: The setting is applied.
type: boolean
required:
- applied
type: object
value:
description: The value of the setting.
type: string
Expand Down Expand Up @@ -4174,7 +4187,7 @@ rules:
resources: ["volumesnapshotclasses", "volumesnapshots", "volumesnapshotcontents", "volumesnapshotcontents/status"]
verbs: ["*"]
- apiGroups: ["longhorn.io"]
resources: ["volumes", "volumes/status", "engines", "engines/status", "replicas", "replicas/status", "settings",
resources: ["volumes", "volumes/status", "engines", "engines/status", "replicas", "replicas/status", "settings", "settings/status",
"engineimages", "engineimages/status", "nodes", "nodes/status", "instancemanagers", "instancemanagers/status",
"sharemanagers", "sharemanagers/status", "backingimages", "backingimages/status",
"backingimagemanagers", "backingimagemanagers/status", "backingimagedatasources", "backingimagedatasources/status",
Expand Down