New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEP: add "Share Manager Scheduling" #8294
Open
derekbit
wants to merge
1
commit into
longhorn:master
Choose a base branch
from
derekbit:issue-7872-lep
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
issue-7872-lep
branch
2 times, most recently
from
April 3, 2024 06:16
86ac2dc
to
25e7a09
Compare
james-munson
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of small items.
derekbit
force-pushed
the
issue-7872-lep
branch
from
April 20, 2024 03:40
25e7a09
to
7423598
Compare
derekbit
force-pushed
the
issue-7872-lep
branch
2 times, most recently
from
April 25, 2024 17:09
0f902ad
to
fe32055
Compare
@james-munson updated the LEP and ready to review. Thank you. |
Longhorn 7872 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
force-pushed
the
issue-7872-lep
branch
from
April 26, 2024 04:03
fe32055
to
7bc5162
Compare
james-munson
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #7872
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context