Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lep): add recurring and manual full backup support #8186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(lep): add recurring and manual full backup support #8186

wants to merge 1 commit into from

Conversation

ChanYiLin
Copy link
Contributor

ref: #7070

Add a proposal of recurring and manual full backup support

@ChanYiLin ChanYiLin self-assigned this Mar 14, 2024
@ChanYiLin ChanYiLin requested a review from a team as a code owner March 14, 2024 08:00
innobead
innobead requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LG. Just a few comments.

BTW, we should consider adding some cases to ensure our existing use cases around back, restore and DR should work as expected.

enhancements/20240314-recurring-and-manual-full-backup-support.md Outdated Show resolved Hide resolved
enhancements/20240314-recurring-and-manual-full-backup-support.md Outdated Show resolved Hide resolved
enhancements/20240314-recurring-and-manual-full-backup-support.md Outdated Show resolved Hide resolved
enhancements/20240314-recurring-and-manual-full-backup-support.md Show resolved Hide resolved
@innobead innobead requested a review from shuo-wu March 14, 2024 10:49
innobead
innobead previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChanYiLin ChanYiLin requested a review from innobead March 15, 2024 07:44
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 2 times, most recently from 29bc52f to 96abbcd Compare March 19, 2024 08:26
@ChanYiLin ChanYiLin marked this pull request as draft March 25, 2024 01:26
@ChanYiLin ChanYiLin changed the title doc(enhancement): add recurring and manual full backup support feat(lep): add recurring and manual full backup support Mar 26, 2024
@ChanYiLin ChanYiLin marked this pull request as ready for review March 26, 2024 06:10
derekbit
derekbit reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the full backup introduce impacts to DR volumes?

@ChanYiLin
Copy link
Contributor Author

ChanYiLin commented Mar 27, 2024 •
edited

Will the full backup introduce impacts to DR volumes?

No, I don't think so
Full Backup is just like Incremental Backup
The difference is only when doing backup, Full Backup will pretend there is no lastBackup to collect all the blocks of the Volume.
From the metadata perspective, it is still a Backup and it will become the lastBackup after completion.
So the DR Volume will pull the lastBackup and do incremental restore in the new cluster

@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 4 times, most recently from f237b35 to 5ad6025 Compare March 27, 2024 08:34
@ChanYiLin
doc(enhancement): add recurring and manual full backup support
2c71def 
ref: longhorn/longhorn 7070

Signed-off-by: Jack Lin <jack.lin@suse.com>
derekbit
derekbit approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChanYiLin ChanYiLin mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@c3y1huang c3y1huang c3y1huang left review comments

@ejweber ejweber ejweber left review comments

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

@innobead innobead Awaiting requested review from innobead

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ChanYiLin @innobead @derekbit @c3y1huang @ejweber @shuo-wu