Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorful text to disk status and add more fitler in backing image page #728

Merged
merged 2 commits into from
May 24, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented May 15, 2024

Goal

  • Add colorful text to disk status
  • Add UUID / Created From filter items in backing image page

Issue

longhorn/longhorn#7293

Test Result

Filter
filter

Colorful disk status
colorful_text

@a110605 a110605 self-assigned this May 15, 2024
@a110605 a110605 marked this pull request as ready for review May 15, 2024 09:57
@a110605 a110605 requested review from ChanYiLin, a team and torchiaf May 15, 2024 09:58
torchiaf
torchiaf previously approved these changes May 21, 2024
Copy link

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605
Copy link
Contributor Author

a110605 commented May 21, 2024

Done rebase with master

@a110605 a110605 requested a review from torchiaf May 21, 2024 08:35
@ChanYiLin
Copy link

LGTM, thanks!

@a110605 a110605 merged commit 30c1e41 into longhorn:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants