fix(robot): skip kubelet terminated pod in get_workload_pods #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
fix-wait_for_workload_pods_stable-filter-pod-terminated-by-kubelet
branch
3 times, most recently
from
0b8b99b
to
6a76ec4
Compare
c3y1huang
force-pushed
the
fix-wait_for_workload_pods_stable-filter-pod-terminated-by-kubelet
branch
2 times, most recently
from
6a7c6e0
to
302e1d8
Compare
longhorn/longhorn-8550 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
fix-wait_for_workload_pods_stable-filter-pod-terminated-by-kubelet
branch
from
302e1d8
to
b16a2b5
Compare
yangchiu
previously requested changes
May 15, 2024
There was a problem hiding this comment.
https://ci.longhorn.io/job/private/job/longhorn-e2e-test/573/ failed.
Need to clarify if it's affected by this PR.
It should be already addressed with the recent force-push commits. |
c3y1huang
deleted the
fix-wait_for_workload_pods_stable-filter-pod-terminated-by-kubelet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8550
What this PR does / why we need it:
longhorn/longhorn#8550 (comment)
Special notes for your reviewer:
Additional documentation or context