Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse to create an XFS volume smaller than 300 MiB (backport #2785) #2803

Merged
merged 1 commit into from
May 28, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 14, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#8488

What this PR does / why we need it:

Prevent the creation of Longhorn PersistentVolumes with fstype: xfs smaller than 300 MiB.


This is an automatic backport of pull request #2785 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner May 14, 2024 03:05
@innobead
Copy link
Member

This is planned for 1.6.3.

@ejweber ejweber force-pushed the mergify/bp/v1.6.x/pr-2785 branch from 3ac61f1 to 3710e35 Compare May 23, 2024 13:55
Copy link
Contributor

@james-munson james-munson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the error message text backwards in one case?

manager/kubernetes.go Show resolved Hide resolved
@james-munson
Copy link
Contributor

Base PR, #2785, had it too, and I missed it there.

Copy link
Contributor

@james-munson james-munson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to ship this way and backport the typo fix for uniformity.

Longhorn 8488

Signed-off-by: Eric Weber <eric.weber@suse.com>
(cherry picked from commit 7e3b690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants