fix: golangci-lint error (backport #2740) #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: PoAn Yang <poan.yang@suse.com> (cherry picked from commit 2306e97)
Signed-off-by: PoAn Yang <poan.yang@suse.com>
innobead
approved these changes
Jun 1, 2024
| AddFunc: bic.enqueueBackingImage, | ||
| UpdateFunc: func(old, cur interface{}) { bic.enqueueBackingImage(cur) }, | ||
| DeleteFunc: bic.enqueueBackingImage, | ||
| }) | ||
| }); err != nil { | ||
| logrus.WithError(err).Fatal("Failed to register event handler for backing image") |
There was a problem hiding this comment.
Didn't notice this Fatal used here, which will cause the process to exit immediately. We should return the err back to the caller and let it handle it instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#7448, longhorn/longhorn#8556
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
This is an automatic backport of pull request #2740 done by [Mergify](https://mergify.com).