Always clean up FailedToScheduleReplica with wrong HardNodeAffinity #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test stepsFollow the reproduce steps in longhorn/longhorn#8522 (comment).
|
|
Regression testing in: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6924/. Results show five failures:
Investigating:
|
ejweber
force-pushed
the
8522-local-replica-corner-case
branch
from
5c5e165
to
ec61947
Compare
Longhorn 8522 Signed-off-by: Eric Weber <eric.weber@suse.com>
…reconcile Longhorn 8522 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
8522-local-replica-corner-case
branch
from
ec61947
to
0ca5eb6
Compare
shuo-wu
approved these changes
May 17, 2024
|
@mergify backport v1.5.x |
✅ Backports have been created
|
|
@mergify backport v1.6.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8522
What this PR does / why we need it:
Delete a failed to schedule replica with HardNodeAffinity if DataLocality is disabled.
Previously, we would only do this if there were enough healthy replicas, but it led to the "deadlock" in longhorn/longhorn#8522 where we would not schedule more replicas until we deleted the failed to schedule one, but we would not delete the failed to schedule one until there were enough healthy ones.
Special notes for your reviewer:
I experimented with changing the behavior of this function even more, but there were some weird side effects. I think it is better to keep it working almost exactly as it did before. I did, however, rearrange a bit.