-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): support recurring and ondemand full backup #2709
Draft
ChanYiLin
wants to merge
1
commit into
longhorn:master
Choose a base branch
from
ChanYiLin:LH7070_support_full_backup
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
7 times, most recently
from
March 26, 2024 06:18
97fecb4
to
e9de905
Compare
ChanYiLin
changed the title
feat(backup): add option validation for backup creation
feat(backup): support recurring and ondemand full backup
Mar 26, 2024
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
2 times, most recently
from
March 29, 2024 09:35
4d99c6c
to
64b4d30
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
5 times, most recently
from
April 2, 2024 08:00
9c979dc
to
a480c0d
Compare
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
from
April 2, 2024 08:45
a480c0d
to
82b847a
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
1 similar comment
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
4 times, most recently
from
May 31, 2024 09:49
fd0c73f
to
f67f889
Compare
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
2 times, most recently
from
May 31, 2024 10:28
ba772b7
to
0307a44
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
2 times, most recently
from
June 3, 2024 08:22
03f17d8
to
1510810
Compare
ref: longhorn/longhorn 7070 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH7070_support_full_backup
branch
from
June 3, 2024 09:56
1510810
to
bcd7246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#7070
backupstore: If the backup has the parameter
backupmodea: full
, it will pretend there is no last backup, and backup all the blocks of the current volume.longhorn-manager:
RecurringJob app
.Spec.Parameters
recurringJob.Status.ExecutionCount
, +1 , then update it backup to the statusjob.executionCount%interval == 0
Backup
.Spec.Parameters
.Status.NewlyUploadedDataSize
and.Status.ReUploadedDataSize
to each Backup. So user can know the data transfer size for each Backup to trace the cost.Webhook
Backup.Spec.Parameters
: only support"backup-mode: full/incremental"
RecurringJob.Spec.Parameters
: only support"full-backup-interval: N"
CRD
.Spec.Parameters
to Backup.Spec.Parameters
to RecurringJob.Status.BackupCount
to BackupVolume..Status.NewlyUploadedDataSize
and.Status.ReUploadedDataSize
to BackupAPI
Parameters
to theSnapshotInput{}
BackupCount
toBackupVolume{}