feat(backup): multiple backup stores support #2182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflicts. Could you fix it @mantissahz? 🙏 |
|
This pull request is now in conflicts. Could you fix it @mantissahz? 🙏 |
mantissahz
force-pushed
the
issue5411
branch
3 times, most recently
from
a782b93
to
142535f
Compare
|
Is this ready for review? |
@innobead Yes, but LEP longhorn/longhorn#6630 is still in review. |
mantissahz
force-pushed
the
issue5411
branch
3 times, most recently
from
c1e1178
to
4cdb679
Compare
james-munson
reviewed
Dec 4, 2023
james-munson
reviewed
Dec 8, 2023
james-munson
reviewed
Dec 8, 2023
james-munson
requested changes
Dec 8, 2023
mantissahz
force-pushed
the
issue5411
branch
from
4e67c1e
to
fe4d30c
Compare
ChanYiLin
requested changes
Dec 12, 2023
Introduce new fields `BackupTargetURL` and `BackupTargetName` in `Spec` of Backup CRD to support multiple backup targets. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Introduce new fields `BackupTargetURL`, `BackupTargetName` and `VolumeName` in `Spec` of BackupVolume CRD to support multiple backup targets. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Introduce new fields `Default` and `ReadOnly` in `Status` of BackupTarget CRD to support multiple backup targets. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
List backup volume CRs by the label `backup-target` that is a backup target name and get last updated backup volume CR by a volume name. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add the backup target mutator and add the finalizer into the backupTarget CR when mutating. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Remove the default backup target from setting controller and add the timer for each backup target for polling interval. Ref:5411 Signed-off-by: James Lu <james.lu@suse.com>
Remove global settings `backup-target`, `backup-target-credential-secret` and `backupstore-poll-interval`. Ref:5411 Signed-off-by: James Lu <james.lu@suse.com>
Modify backup volume controller to support multiple backup stores support. Synchronize and handle the backup volumes information from different backup targets with the same backup volume name or not. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Modify backup controller to support multiple backup stores support. Synchronize and handle the backup information from different backup targets with the same backup volume name or not. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Replace the value of the field `BackupTargetURL` of Backup CR spec by the default backup target URL if it is empty when mutating. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
For restoration, the BackupVolume CR name will not be the same to the backup volume name in the `fromBackup` URL in Volume spec. Set engine.Spec.BackupVolume as BackupVolume CR name. Introduce a new field `BackupTargetName` in Engine Spec to get the backup target status when creating a volume by restoring a backup. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add a new filed `BackupTargetName` in RecurringJob spec and related data strucurtes of APIs and recurring job app. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
The first backup target will become the default backup target whether the `Default` in `Spec` is set `true` or not. If it is not the first backup target with the `Default` in `Spec` set `true`, backup target controller will set `Default` false both in `Spec` and `Status` for previous default backup target and then setup new backup target as a default one. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Get the default backup target by `Status.Default` instead of gettting backup target by `types.DefaultBackupTargetName`. Ref:5411 Signed-off-by: James Lu <james.lu@suse.com>
Check if creating backup is on a read-only backup target or not. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add secret HTTP apis: "SecretCreate", "SecretGet", "SecretList", "SecretUpdate" and "SecretDelete". Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add more parameters in creating BackupVolume for testing volume_controller.go Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Support multiple backup stores. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Move AWS IAM Role Annotation implementations to datastore/kubernetes.go and trigger it by backup target validator. Ref: 5411, 6947 Signed-off-by: James Lu <james.lu@suse.com>
Upgrade CRs for Engine, BackupTarget, BackupVolume, Backup, and RecurringJob. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
sets.String is deprecated: use generic Set instead Ref: longhorn/longhorn 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: longhorn/longhorn 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: longhorn/longhorn 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: longhorn/longhorn 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: longhorn/longhorn 5411 Signed-off-by: James Lu <james.lu@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple backup stores to create, delete and update them.
Remove the
defaultbackup target instead usingDefaultflag inBackupTargetCR spec.Adding a flag
ReadOnlyinBackupTargetCR spec prevent backups from being created and storing on this remote backup target.And provide HTTP endpoints to create, delete, update and list secrets.
Ref: longhorn/longhorn#5411