Feature/implement different actions #74
Conversation
…lugins#65 and logstash-plugins#66 Makes plugin work with mongodb driver, version 2.6 (again)
in addition to inserting new ones
fixing mongo driver version to 2.6
probably doesn't make sense in most use cases and causes trouble if size or order of array elements changes
|
Locally tests are green. So as usual ;) Works on my machine... Can anybody please tell me which are the correct ruby versions for which elastic stack versions and for which ruby versions the tests have to run? |
|
Could anybody please take a look and let me know whether my changes make sense for you, too? |
|
@nilskuhn I am considering this patch for implementing a query that updates documents using the https://docs.mongodb.com/manual/reference/operator/update/inc/ I wonder if I can do that - I would need to spike that probably but some hint from you would be greatly appreciated 😄 |
|
Ok if I understand this right we don't have that option at the moment, it would mean adding a custom |
|
@nilskuhn I am trying your PR - I am planning to add the Do you have any input on this? |
| query_value is used like described https://docs.mongodb.com/ruby-driver/v2.6/tutorials/ruby-driver-bulk-operations[here] | ||
| for `update` and `replace` examples: | ||
|
|
||
| :filter => {query_key => query_value} |
There was a problem hiding this comment.
The usage of this is not really clear from this example, would you mind improving it a bit?
There was a problem hiding this comment.
Was a week on vacation. Will look into this asap.
There was a problem hiding this comment.
No problem take your time as you saw I went a bit beyond the original intent 😃
Hope you like the result
There was a problem hiding this comment.
It gets clear if you follow the link to mongodb documentation I added to ascii-documentation and take a look at update and replace examples.
There was a problem hiding this comment.
So in general you don't want to update a document in mongodb with whole logstash event but instead just increment some fields in mongodb? And do you want to read size to increment fields with from logstash event?
There was a problem hiding this comment.
Yeah I am building projections from the events and I am doing now something like:
if [@metadata][event_type] == "stock.updated" and [quantity] > 0 {
mongodb {
id => "orders.projection.mongodb.stock-update"
uri => "${MONGO_DNS}"
collection => "product-aggregates"
database => "carts"
isodate => true
action => "update"
filter => {
"_id" => "[_id]"
"store_id" => "[store_id]"
}
update_expressions => {
"$inc" => {"stock" => "[stock_delta]"}
}
}
}
|
why not update? I need a feature for updating MongoDB documents. |
This is an implementation for issue 16.