Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geodesic Interpolated Starting Path #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GabrielBram
Copy link
Collaborator

@GabrielBram GabrielBram commented Apr 16, 2024

Implements the initial path construction specified in: https://pubs.aip.org/aip/jcp/article/150/16/164103/198363/Geodesic-interpolation-for-reaction-pathways.

Code by and large lifted from the repository associated with the paper: https://github.com/virtualzx-nad/geodesic-interpolate/tree/master. However, this implementation honours FixAtoms constraints and periodic boundary conditions in ASE.

Essentially gives a more robust starting guess for the initial path than linear interpolation. Although the full geodesic interpolation algorithm is not implemented, the path should give a better starting guess for IDPP (IDPP uses the linear interpolation as a starting guess and suffers from nasty clashes if two atoms pass through one another).

Test case shows a 120 degree rotation of a CH3 group in ethane, which would otherwise fail spectacularly with the default IDPP interpolation without a better starting guess.

Best use for now would look like:

from carmm.build.neb.geodesic import GeodesicInterpolator
from ase.mep import idpp_interpolate, NEB

Geodesic = GeodesicInterpolator(initial, final, 6, None)
Geodesic.init_path()

idpp_interpolate(Geodesic.images, mic=True)
mep = NEB(Geodesic.images)
...

…ay implement full algorithm later, but for now, gives a more robust starting guess for the IDPP interpolator.
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 88.84%. Comparing base (001ce56) to head (e8452a0).

Files Patch % Lines
carmm/build/neb/geodesic.py 95.83% 4 Missing ⚠️
carmm/build/neb/geodesic_utils.py 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   88.44%   88.84%   +0.40%     
==========================================
  Files          82       85       +3     
  Lines        3340     3514     +174     
==========================================
+ Hits         2954     3122     +168     
- Misses        386      392       +6     
Flag Coverage Δ
unittests 88.84% <96.55%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabrielBram
Copy link
Collaborator Author

(A warning: This is all desperately uncommented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant