Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulliken.py, removed redundant functionalities for plot data, added f… #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AkashHiregange
Copy link
Collaborator

…urther documentation and comments to describe the functionality to make life easier. Removed the deprecated matplotlib funcitonality Axes from graphs.py

  • Added further documentation and comments to the mulliken.py file
  • Removed redundant functionality and changed a few variable names to make life easier
  • Removed the deprecated matplotlib import Axes from graph.py and added the latest import line. (This was necessary for the tests to pass)
  • All the tests for mulliken analyse works

…urther documentation and comments to describe the functionality to make life easier. Removed the deprecated matplotlib funcitonality Axes from graphs.py
…t this change fixes the issue in this branch. If yes, then the changes made by Andy's pull request logsdail#156 could be merged into main
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (6daf5ba) to head (e4e7245).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   88.23%   88.15%   -0.09%     
==========================================
  Files          80       80              
  Lines        3265     3241      -24     
==========================================
- Hits         2881     2857      -24     
  Misses        384      384              
Flag Coverage Δ
unittests 88.15% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkashHiregange AkashHiregange mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant