fix: use no indentation for json logging #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling indentation for json in logs by setting default json serializer settings causes those logs to be split over multiple entries due to the new line characters. To avoid this the serializer formatting should always be set to override as "None".
|
Just dropping a "this would be nice if someone would merge this" becuase I encountered this and ended up needing to just remove the default formatting from my app to get loggly to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling indentation for json in logs by setting default json serializer settings causes those logs to be split over multiple entries due to the new line characters. To avoid this the serializer formatting should always be set to override as "None".