Added static analysis step to the CI.

[rupertj]

No description provided.

[finnlewis]

Thanks for this @rupertj

I understand from @willguv that we're aiming to bring localgov_publications into the default core localgov installation.

With that in mind, it would be good to be consistent in our testing across the repositories.

@millnut is currently working on setting up shared workflows, specifically with the aim of pulling in consistent workflows across the board, so it would be great to get input from @millnut on this pull request.

Also flagging for @stephen-cox too... should we be aiming to be consistent with https://github.com/localgovdrupal/localgov_project/blob/3.x/.github/workflows/test.yml in the short term?

Might we want to add some of these changes to localgov_project?

[millnut]

Hi @rupertj if you could update this to use the new shared workflow that would be great. I've added an example to the localgov/localgov_alert_banner.

I know on Slack we discussed the possibility of modules having a higher PHPStan level vs the default level and I'm all for this, especially with the Drupal Core plans to increase this level in future.

What I think would be good is creating a PR at https://github.com/localgovdrupal/localgov_shared_workflows to add an optional input for the workflow, something like use_module_phpstan_config or similar which would allow you to use a module-level config.

[stephen-cox]

As @millnut has mentioned, I think we're going to move all Github testing config to use https://github.com/localgovdrupal/localgov_shared_workflows/blob/1.x/.github/workflows/test-module.yml, so I suggest moving the change to the workflow there.