Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows filtering by node title on content listing page #446

Open
wants to merge 11 commits into
base: 4.x
Choose a base branch
from

Conversation

markconroy
Copy link
Member

@markconroy markconroy commented Mar 11, 2024

Closes #445

Screenshot 2024-03-11 at 16 06 26

stephen-cox and others added 10 commits August 3, 2023 15:42
…s-always-on

Only set 'Generate automatic url alias box' for new nodes
…microsites view (#417)

* Changed Microsites overview view so it's only accessible to Microsite Controllers #416

* Removed nonexistent permission 'bypass group access'

* Added 'access microsites overview' permission

* Added update hook to fix microsites overview access for existing sites

* Remove 'bypass group access' permission from Microsite controllers
@stephen-cox stephen-cox self-requested a review March 12, 2024 12:46
@stephen-cox
Copy link
Member

@markconroy I'm having a look at this, but it's based from and going into the 3.x branch.

The default branch has recently become the 4.x branch and we don't want people installing the 3.x branch any more. Can you update this to use the 4.x branch?

@markconroy markconroy changed the base branch from 3.x to 4.x March 15, 2024 09:16
@markconroy
Copy link
Member Author

@stephen-cox that's updated to 4.x now.

@stephen-cox
Copy link
Member

I've given this a whirl and it doesn't look like the override config is getting applied, although I haven't had any time to check what the issue is. Will need to investigate.

@ekes
Copy link
Member

ekes commented Mar 26, 2024

I've given this a whirl and it doesn't look like the override config is getting applied, although I haven't had any time to check what the issue is. Will need to investigate.

At the moment we're just importing the new displays:

  if ($view->id() == 'group_nodes') {
    $group_node_view = Yaml::decode(file_get_contents($module_path . '/config/overrides/views.view.group_nodes.yml'));
    $displays = $view->get('display');
    $displays['microsite_page'] = $group_node_view['display']['microsite_page'];
    $displays['microsite_dashboard_embed'] = $group_node_view['display']['microsite_dashboard_embed'];
    $view->set('display', $displays);
  }

https://github.com/localgovdrupal/localgov_microsites_group/blob/9234f000f330bde49a5df155c1b116696b27806f/localgov_microsites_group.module#L55C1-L61C4

So we should decide if we're going to replace the whole view, or continue to patch into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants