Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sets banner image to aria-hidden true #420

Closed
wants to merge 1 commit into from
Closed

sets banner image to aria-hidden true #420

wants to merge 1 commit into from

Conversation

markconroy
Copy link
Member

Closes #419

@msayoung
Copy link
Member

comments #419

@finnlewis
Copy link
Member

Leaving this for now at Merge Monday, allowing discussion on #419 to come to a conclusion

@finnlewis finnlewis mentioned this pull request Apr 17, 2023
Open
@markconroy
Copy link
Member Author

I'm going to close this. Looks like we won't be using this PR, and will look to fix this if it's needed by adding a field on the paragraph type.

@markconroy markconroy closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis Awaiting requested review from finnlewis

@msayoung msayoung Awaiting requested review from msayoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should hero banner be marked as "decorative"
3 participants
@markconroy @msayoung @finnlewis