Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should hero banner be marked as "decorative" #419

Open
markconroy opened this issue Mar 22, 2023 · 4 comments
Open

Should hero banner be marked as "decorative" #419

markconroy opened this issue Mar 22, 2023 · 4 comments

Comments

@markconroy
Copy link
Member

This came up during testing with a client:

Can the homepage hero be decorative/skipped alt attribute?

Due to the nature of the banner image against the page this should never hold value to understanding context of page, therefore should be skipped so it's not distracting.

What are our thougths?

@willguv
Copy link
Member

willguv commented Mar 22, 2023

Yes, think so. It's not essential to the understanding of the page and announcing the alt tag delays the user reaching the main nav

@msayoung
Copy link
Member

Sorry @markconroy - I didnt see this earlier.

I disagree that it should be ignored by default.
It completely depends on the image that has been used - in which case marking it decorative should be on a case by case basis.

An approach would be to add a decorative image flag to the banner image paragraph.
See: localgovdrupal/localgov#506

@finnlewis
Copy link
Member

@msayoung and @markconroy could you confirm the preferred approach for #420 ?

@markconroy
Copy link
Member Author

I'm happy to agree with Maria, and we fix this on a case-by-case basis for each client. Or file a follow up issue if we need it to add a flag to the paragraph type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants