Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ’„ style: Modify bedrock provided model #2473

Merged
merged 2 commits into from May 20, 2024
Merged

๐Ÿ’„ style: Modify bedrock provided model #2473

merged 2 commits into from May 20, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented May 13, 2024 •
edited

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

ไฟฎๆ”นbedrockๆไพ›็š„ๆจกๅž‹

Modify bedrock provided model

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented May 13, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 93.33%. Comparing base (84c69c9) to head (774d41d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2473   +/-   ##
=======================================
  Coverage   93.32%   93.33%           
=======================================
  Files         334      334           
  Lines       20041    20063   +22     
  Branches     1515     1516    +1     
=======================================
+ Hits        18704    18726   +22     
  Misses       1337     1337

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

arvinxx
arvinxx requested changes May 14, 2024
View reviewed changes
src/config/modelProviders/bedrock.ts Show resolved Hide resolved
src/config/modelProviders/bedrock.ts Outdated Show resolved Hide resolved
src/config/modelProviders/bedrock.ts Outdated Show resolved Hide resolved
src/config/modelProviders/groq.ts Outdated Show resolved Hide resolved
src/libs/agent-runtime/deepseek/index.test.ts Outdated Show resolved Hide resolved
@RubuJam RubuJam closed this May 14, 2024
@RubuJam RubuJam reopened this May 14, 2024
@RubuJam RubuJam requested a review from arvinxx May 14, 2024 06:16
arvinxx
arvinxx requested changes May 14, 2024
View reviewed changes
src/config/modelProviders/bedrock.ts Outdated Show resolved Hide resolved
@RubuJam RubuJam requested a review from arvinxx May 14, 2024 08:08
@RubuJam
Copy link
Contributor Author

RubuJam commented May 14, 2024

@arvinxx ่ฆไธๅ…ˆๆŠŠ่ฟ™ไธชPRๅˆๅนถไบ†๏ผŒๆˆ‘ๅŽ้ขๅŠ ๆ–นๆณ•ไบ†ๅฆๅค–ๅ†ๆไธ€ไธชPR๏ผŸ

Merge this PR first, and I'll add the method later and mention another PR?

@RubuJam RubuJam closed this May 20, 2024
@RubuJam RubuJam reopened this May 20, 2024
@RubuJam RubuJam requested a review from arvinxx May 20, 2024 03:08
arvinxx
arvinxx approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Thanks!

@arvinxx arvinxx merged commit a1fabf6 into lobehub:main May 20, 2024
4 of 5 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @RubuJam โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request May 20, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v0.160.4 [skip ci]
911c98c 
### [Version 0.160.4](v0.160.3...v0.160.4)
<sup>Released on **2024-05-20**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Modify bedrock provided model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Modify bedrock provided model, closes [#2473](#2473) ([a1fabf6](a1fabf6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.160.4 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

@RubuJam RubuJam deleted the bedrock branch May 20, 2024 04:39
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 20, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.40.2 [skip ci]
8cab349 
### [Version&nbsp;1.40.2](v1.40.1...v1.40.2)
<sup>Released on **2024-05-20**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Modify bedrock provided model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Modify bedrock provided model, closes [lobehub#2473](https://github.com/bentwnghk/lobe-chat/issues/2473) ([a1fabf6](a1fabf6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
akvsdk pushed a commit to akvsdk/lobe-chat that referenced this pull request May 20, 2024
@RubuJam @akvsdk
๐Ÿ’„ style: Modify bedrock provided model (lobehub#2473)
a611251 
* ๐Ÿ’„ style: Modify bedrock provided model

* ๐Ÿ’„ style: Adjust copywriting
akvsdk pushed a commit to akvsdk/lobe-chat that referenced this pull request May 20, 2024
@semantic-release-bot @akvsdk
๐Ÿ”– chore(release): v0.160.4 [skip ci]
9b4d14e 
### [Version&nbsp;0.160.4](lobehub/lobe-chat@v0.160.3...v0.160.4)
<sup>Released on **2024-05-20**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Modify bedrock provided model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Modify bedrock provided model, closes [lobehub#2473](lobehub#2473) ([a1fabf6](lobehub@a1fabf6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxjeru sxjeru sxjeru left review comments

@arvinxx arvinxx arvinxx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RubuJam @lobehubbot @sxjeru @arvinxx