Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: add system agent to select another model provider for translation #1902

Merged
merged 6 commits into from May 21, 2024

Conversation

phsontung
Copy link
Contributor

@phsontung phsontung commented Apr 5, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

Screenshot from 2024-04-05 08-22-06

Screenshot from 2024-04-05 08-26-49

📝 补充信息 | Additional Information

Copy link

vercel bot commented Apr 5, 2024

@phsontung is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @phsontung

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@phsontung phsontung changed the title Allow to select another model provider for translation action ✨ Allow to select another model provider for translation action Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.35%. Comparing base (c733fcf) to head (5b60012).
Report is 3 commits behind head on main.

Current head 5b60012 differs from pull request most recent head 1c415ce

Please upload reports for the commit 1c415ce to get more accurate results.

Files Patch % Lines
src/store/user/slices/settings/actions/general.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1902    +/-   ##
========================================
  Coverage   93.34%   93.35%            
========================================
  Files         334      334            
  Lines       20164    20206    +42     
  Branches     1528     2385   +857     
========================================
+ Hits        18822    18863    +41     
- Misses       1342     1343     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Apr 11, 2024

@phsontung hello, sorry for the later reply. Please rebase the config.

@phsontung
Copy link
Contributor Author

@phsontung hello, sorry for the later reply. Please rebase the config.

I have synced with main branch and update source code. Please help review bro.

@arvinxx
Copy link
Contributor

arvinxx commented Apr 22, 2024

@phsontung I think it's really a great idea to have system agent config for LobeChat. but I prefer a single tab Named "System Agent" for this. So we can set different models to summarize, translate, auto agent meta and so on. And in this PR just adding translate config is fine.

src/const/settings/index.ts Outdated Show resolved Hide resolved
src/store/chat/slices/enchance/action.ts Outdated Show resolved Hide resolved
@arvinxx arvinxx changed the title ✨ Allow to select another model provider for translation action ✨ feat: add system agent to select another model provider for translation May 21, 2024
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:35pm

@arvinxx arvinxx merged commit 3945387 into lobehub:main May 21, 2024
4 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @phsontung ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request May 21, 2024
## [Version 0.161.0](v0.160.8...v0.161.0)
<sup>Released on **2024-05-21**</sup>

#### ✨ Features

- **misc**: Add system agent to select another model provider for translation.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add system agent to select another model provider for translation, closes [#1902](#1902) ([3945387](3945387))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.161.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 21, 2024
## [Version&nbsp;1.41.0](v1.40.4...v1.41.0)
<sup>Released on **2024-05-21**</sup>

#### ✨ Features

- **misc**: Add system agent to select another model provider for translation.

#### 💄 Styles

- **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add system agent to select another model provider for translation, closes [lobehub#1902](https://github.com/bentwnghk/lobe-chat/issues/1902) ([3945387](3945387))

#### Styles

* **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button, closes [lobehub#2500](https://github.com/bentwnghk/lobe-chat/issues/2500) [lobehub#2511](https://github.com/bentwnghk/lobe-chat/issues/2511) [lobehub#2581](https://github.com/bentwnghk/lobe-chat/issues/2581) ([0c62fb7](0c62fb7))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants