Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sparse] propagate sparsity properly when decompose torch operations. #3318

Merged
merged 4 commits into from May 15, 2024
Merged

[sparse] propagate sparsity properly when decompose torch operations. #3318

merged 4 commits into from May 15, 2024

Conversation

PeimingLiu
Copy link
Member

No description provided.

aartbik
aartbik approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@aartbik aartbik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and approved, but since we are touching a bit more core torch here, please wait for Stella to approve as well

also, please double check if we need to fix the bazel build (as a courtesy), since we are touching a CMake file

@PeimingLiu
Copy link
Member Author

@stellaraccident

@PeimingLiu PeimingLiu force-pushed the resnet branch 2 times, most recently from ef79f83 to 34acbbb Compare May 13, 2024 20:43
@PeimingLiu PeimingLiu requested a review from ramiro050 May 15, 2024 00:16
ramiro050
ramiro050 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeimingLiu PeimingLiu merged commit ccb772c into llvm:main May 15, 2024
3 checks passed
@sjain-stanford sjain-stanford mentioned this pull request May 16, 2024
Merged
sjain-stanford added a commit that referenced this pull request May 17, 2024
@sjain-stanford
[Bazel] Add SparseTensorDialect deps (#3357)
706efaf 
Required after #3318 landed.

GHA:
https://github.com/sjain-stanford/torch-mlir/actions/runs/9120607050/job/25078271790
BaneTrifa pushed a commit to BaneTrifa/torch-mlir that referenced this pull request May 24, 2024
@PeimingLiu
[sparse] propagate sparsity properly when decompose torch operations. (…
18d3474 
…llvm#3318)
BaneTrifa pushed a commit to BaneTrifa/torch-mlir that referenced this pull request May 24, 2024
@sjain-stanford
[Bazel] Add SparseTensorDialect deps (llvm#3357)
015feff 
Required after llvm#3318 landed.

GHA:
https://github.com/sjain-stanford/torch-mlir/actions/runs/9120607050/job/25078271790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 approved these changes

@aartbik aartbik aartbik approved these changes

@yinying-lisa-li yinying-lisa-li yinying-lisa-li approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeimingLiu @ramiro050 @aartbik @yinying-lisa-li