Update setup.py #3159
Open
Update setup.py #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary comments and whitespace to make the code cleaner and more concise. Simplified the check_env_flag function for better readability. Consolidated the definition of PACKAGE_VERSION to make it cleaner. Removed redundant environment variable checks and simplified their usage. Cleaned up the CustomBuild and CMakeBuild classes, removing redundant code and improving readability. Simplified the CMakeExtension class. Reorganized the imports for better readability. Removed unnecessary conversions and simplified some code blocks. Simplified the setup() function call for better readability.
| @@ -1,84 +1,41 @@ | |||
| # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | |||
There was a problem hiding this comment.
Can you preserve the license after the shebang line.
Also retain any relevant docs on env var usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary comments and whitespace to make the code cleaner and more concise.
Simplified the check_env_flag function for better readability.
Consolidated the definition of PACKAGE_VERSION to make it cleaner.
Removed redundant environment variable checks and simplified their usage.
Cleaned up the CustomBuild and CMakeBuild classes, removing redundant code and improving readability.
Simplified the CMakeExtension class.
Reorganized the imports for better readability.
Removed unnecessary conversions and simplified some code blocks.
Simplified the setup() function call for better readability.