Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Add support for gnu range on switch stmts #599

Merged
merged 2 commits into from May 21, 2024

Conversation

wenpen
Copy link
Contributor

@wenpen wenpen commented May 11, 2024

Fix #596

@wenpen wenpen changed the title switch support gnu range [CIR][CIRGen] switch support gnu range May 14, 2024
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue, almost good to go!

clang/test/CIR/CodeGen/switch.cpp Outdated Show resolved Hide resolved
case A ... C:
case D:
case E ... F:
case L ... A:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if this tests from G to L, so we can see the numbers work as intended.

@bcardosolopes bcardosolopes changed the title [CIR][CIRGen] switch support gnu range [CIR][CIRGen] Add support for gnu range on switch stmts May 14, 2024
@wenpen wenpen requested a review from bcardosolopes May 17, 2024 05:34
@bcardosolopes bcardosolopes merged commit e3b160f into llvm:main May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add switch support for GNU range
2 participants