[CIR][CIRGen] Support for signed #cir.ptr #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
May 10, 2024
The constant initialization isn't related to the pointee. We should be able to write #cir.ptr<-1 : i64> : !cir.ptr<whatever>
|
Thanks! I updated this PR. |
bcardosolopes
requested changes
May 14, 2024
| let description = [{ | ||
| A pointer attribute is a literal attribute that represents an integral | ||
| value of a pointer type. | ||
| }]; | ||
| let builders = [ | ||
| AttrBuilderWithInferredContext<(ins "Type":$type, "uint64_t":$value), [{ | ||
| return $_get(type.getContext(), type.cast<mlir::cir::PointerType>(), value); | ||
| AttrBuilderWithInferredContext<(ins "Type":$type, "int64_t":$value), [{ |
There was a problem hiding this comment.
I suggest we remove this functionality, better if we force whomever is creating the attribute to pass in the mlir::IntegerType, assumptions might lead to subtle mistakes here.
bcardosolopes
approved these changes
May 16, 2024
|
Will merge on the code formatting gets fixed. |
thanks! Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant initialization isn't related to the pointee. We should be able to write #cir.ptr<-1 ： i64> : !cir.ptr