[CIR][CIRGen] Add CIRGen support for float16 and bfloat #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
force-pushed
the
main
branch
2 times, most recently
from
c4db6d0
to
e197d4e
Compare
|
Nathan just did a rebase, can you please update? Sorry for the churn |
|
Rebased onto the latest |
bcardosolopes
requested changes
May 2, 2024
This patch adds two new CIR floating-point types, namely `!cir.f16` and `!cir.bf16`, to represent the float16 format and bfloat format, respectively. CIRGen for the two new types and scalar expressions involving these two new types is also included in this patch. This patch converts the clang extension type `_Float16` to `!cir.f16`, and converts the clang extension type `__bf16` type to `!cir.bf16`.
Lancern
force-pushed
the
half-precision-fp
branch
from
90366de
to
3ea7d4c
Compare
|
Rebased onto the latest
|
Lancern
changed the title
bcardosolopes
requested changes
May 14, 2024
There was a problem hiding this comment.
Great, thanks for all the promotion related improvements, they are very nice.
LLVMIR lowering, and MLIR lowering for the two new types are also included in this PR.
Fine for this, but for next PRs I might start getting more picky about adding LLVM IR checks, the unary questions below are one example where checking intended LLVM output could have made some of the choices easier.
bcardosolopes
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new CIR floating-point types, namely
!cir.f16and!cir.bf16, to represent the float16 format and bfloat format, respectively.This PR converts the clang extension type
_Float16to!cir.f16, and converts the clang extension type__bf16type to!cir.bf16. The type conversion for clang extension type__fp16is not included in this PR since it requires additional work during CIRGen.Only CIRGen is implemented here, LLVMIR lowering / MLIR lowering should come next.