fix: apipath fix on windows platform #10
Conversation
|
|
lib/loaders/entry-loader.js
Outdated
| const apiPath = path.join(__dirname, 'api.js'); | ||
|
|
||
| var apiPath = path.join(__dirname, 'api.js') | ||
| if(/win32/gi.test(process.platform)){ |
There was a problem hiding this comment.
I would suggest using loaderUtils.stringifyRequest to stringify the module path, it will cover more edge cases.
There was a problem hiding this comment.
Yeah, good advise ! I'll commit the code later.
There was a problem hiding this comment.
I would suggest using
loaderUtils.stringifyRequestto stringify the module path, it will cover more edge cases.
I'd tried to use loaderUtils.stringifyRequest,the following code
loaderUtils.stringifyRequest(this,path.join(__dirname, 'api.js'))
// return
// \"e:/a.js\"
It seems still can't resolve it.
What's your opinion?
There was a problem hiding this comment.
Have you tested it in a Windows machine?
There was a problem hiding this comment.
Have you tested it in a Windows machine?
yeah,i had tested it in my windows machine.
There was a problem hiding this comment.
Have you tested it in a Windows machine?
The transform result on windows is require('!!"E:/api.js"') .
loaderUtils.stringifyRequest just like JSON.stringify to parse the string.
There was a problem hiding this comment.
I would suggest using
loaderUtils.stringifyRequestto stringify the module path, it will cover more edge cases.
Hi,I had tried another way to fix the problem. Look at the commit fb7a4aa8a38856ab99796a2486d4c44d43af31b4. It works on my windows and mac machine.
fix the path on windows
|
I have the same problem. Is this repo still maintained? Or we should fork? |
|
How is it going now? |
|
It is not going. I think Webpack 5 has this out of the box anyway, doesn't it? |
|
I had fixed it，by this pr after fork the project. |
A Windows path problem.
#L3
It should be
apiPath.replace(/\\/ig,'\\\\').Otherwise,the program will transformE:\code\app.jsintoE:codeapp.jsat line 11 because of the template code.Just make a judgement it'll runs ok!