Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodejs tool layer #491

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rene-descartes2021
Copy link
Collaborator

@rene-descartes2021 rene-descartes2021 commented Jun 9, 2022

If able to, this layer will download the Node.js source and build if Node.js is not detected on system.
Node.js includes the Yarn and npm tools.

In order to make a project zero-install, you must be able to use it as soon as you clone it.

This approaches a zero-install workflow to allow users to immediately use the lsp layer to download and use language servers as needed, and also coc.nvim.
I also prefer to allow users the option of automatically building dependencies from source where possible, instead of them having to manually download binaries and read relevant installation documentation themselves.

Other changes:

  • Some revision of lsp layer in approach of the zero-install goal.

Minor shortcomings:

  • Building Node.js not supported on Windows as I can't test. It should attempt to build if Visual Studio Build Tools 2019+ are on their system.

Blocking Bug: There is a problem with AsyncRun being used within a vim-plug job. I need to resolve that problem before I can add this layer. I found a workaround involving a timer to wait until vim-plug had finished (re)loading the plugins (which broke AsyncRun). A proposed event in vim-plug will remove the need for this timer, waiting on that author.
Contingent on: #500.

@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 3 times, most recently from 30a10aa to c2a50b7 Compare June 9, 2022 22:44
@rene-descartes2021 rene-descartes2021 marked this pull request as draft June 10, 2022 15:31
@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 8 times, most recently from 178d6e2 to 36da67d Compare June 15, 2022 19:12
@rene-descartes2021 rene-descartes2021 marked this pull request as ready for review June 16, 2022 14:44
@rene-descartes2021 rene-descartes2021 marked this pull request as draft June 16, 2022 23:20
@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 2 times, most recently from 1fd959e to dee8b90 Compare June 22, 2022 21:25
@rene-descartes2021 rene-descartes2021 marked this pull request as ready for review June 22, 2022 21:31
@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 2 times, most recently from db82590 to 5cc90a2 Compare June 27, 2022 23:59
@rene-descartes2021 rene-descartes2021 marked this pull request as draft June 28, 2022 18:57
@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 2 times, most recently from 64f18d0 to 6e7bf66 Compare July 8, 2022 00:02
@rene-descartes2021 rene-descartes2021 force-pushed the nodejs-layer branch 4 times, most recently from 2d46a9b to d5f42e0 Compare August 3, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant