Support attribute enumeration for files and directories #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
feature/upstream-enum-attr
branch
from
0e41b8a
to
9a9f2f8
Compare
|
Note: These changes are part of the Sming LittleFS library, used by Sming. |
mikee47
force-pushed
the
feature/upstream-enum-attr
branch
from
2b592b2
to
caa0b9d
Compare
geky
added
enhancement
needs minor version
|
look like some feature is also implemented in: #636 |
|
Hi, yes, sorry this PR did not go in this release, due to time I was only looking at PRs with smaller scopes this release. I'm slow to bring in new APIs since they need to be supported for quite a while for backwards compatibility reasons. This looks like a very interesting PR, thank @mikee47 for putting it together. In particular I will need to see how it interacts with #580 and #513 (though #513 may come in much later due to being an API breaking change) |
Extends regular `lfs_stat` by querying set of attribute at the same time. Improves performance of directory listings.
Supports attribute manipulation on open files. Important for updating things like security descriptors, timestamps, etc. Note: Attempting to remove registered attributes fails. This could be handled by marking registered attribute as dirty.
Allows file attributes to be efficiently enumerated, required for filesystem backup, etc.
Allows attributes to be accessed more efficiently, and enumerated
mikee47
force-pushed
the
feature/upstream-enum-attr
branch
from
caa0b9d
to
a146db8
Compare
Tests passed ✓, Code: 18212 B (+6.7%), Stack: 1440 B (+0.0%), Structs: 832 B (+2.5%)
|
slaff
pushed a commit
to SmingHub/Sming
that referenced
this pull request
May 27, 2024
This PR updates the [Sming-LittleFS](https://github.com/mikee47/Sming-LittleFS) library, which implements IFS for the [littlefs](https://github.com/littlefs-project/littlefs) file system. The library still uses a fork of littlefs because it adds attribute enumeration support - see upstream [PR request](littlefs-project/littlefs#636). This has now been rebased on version 2.9.3 - see [releases](https://github.com/littlefs-project/littlefs/releases) for details of all the changes. Here's a (non-exhaustive) summary: - Improved RAM usage - Improved performance - v2.5.0 removed all recursion - v2.6.0 bump the on-disk minor version of littlefs from lfs2.0 -> lfs2.1. "This change is backwards-compatible, but after the first write with the new version, the image on disk will no longer be mountable by older versions of littlefs." - v2.7.0 Add `lfs_fs_stat` as an analog for the POSIX stavfs. This isn't currently used by Sming-LittleFS. - v2.9.0 `rename` now returns LFS_ERR_NOTDIR if the source is a regular file and the destination is a directory. This better aligns with POSIX. There are no functional changes to the library, but the samples have been simplified. An additional sample has been added to assess wear levelling behaviour (as a result of discussion #2771).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some additional attribute enumeration features.
Add
lfs_statcfg,lfs_dir_readcfgfunctionsExtends regular
lfs_statby querying set of attribute at the same time.Improves performance when generating directory listings.
Add
lfs_file_getattr,lfs_file_setattr,lfs_file_removeattrSupports attribute manipulation on open files.
Important for updating things like security descriptors, timestamps, etc.
Note: Includes checks for registered attributes.
Attempting to remove registered attributes fails.
This could be handled by marking registered attribute as dirty.
Add
lfs_file_enumattr()functionAllows file attributes to be efficiently enumerated,
required for filesystem backup, etc.
Support opening handle to directory
Allows attributes to be accessed more efficiently, and enumerated