chore: unpin Advanced Alchemy #3491
Merged
+959
−703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
cofin
commented
May 11, 2024
cofin
commented
May 11, 2024
github-actions
bot
added
area/docs
|
For the 3.8 failure, you'd either have to update the AA pagination class to use the typing generic collection types (ie |
|
Thanks - Just saw this as I came to the same conclusions. Resolved in litestar-org/advanced-alchemy#191 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3491 +/- ##
==========================================
- Coverage 98.30% 98.30% -0.01%
==========================================
Files 328 328
Lines 14884 14875 -9
Branches 2366 2365 -1
==========================================
- Hits 14632 14623 -9
Misses 115 115
Partials 137 137 ☔ View full report in Codecov by Sentry. |
peterschutt
reviewed
May 12, 2024
Co-authored-by: Peter Schutt <peter.github@proton.me>
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3491 |
peterschutt
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unpins Advanced Alchemy.
This allows version
0.9.3to be installed with tehlitestar[sqlalchemy]command group.This enables the following:
to_schemafrom theServiceused there (see the fullstack repository for usage details)However, this AA release also had to integrate it's own copies of the Litesatr
OffsetPaginationdataclass. Litestar will attempt to use this version of the dataclass when a supported version is installed. This is implemented similar to how the filters infilters.pywork currently.Closes