docs: Adjusted guard typing to union of connection classes #3385
+298
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update incorrect statement in middleware/authentication
github-actions
bot
added
area/docs
aranvir
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 324 324
Lines 14774 14774
Branches 2346 2346
=======================================
Hits 14520 14520
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
|
Could you base this off of the #3344 branch? |
aranvir
force-pushed
the
docs/security-guards-update
branch
from
e7f1161
to
d914230
Compare
github-actions
bot
added
the
area/middleware
Checked out that branch and cherry picked my changes on top of that and force-pushed it on my fork branch - so should be the right history now.. should I change the target or is main okay? |
aranvir
changed the title
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ASGIConnection | Request | WebSocketto better reflect the object type that is passed to this handlerCloses
Closes #3356