Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update usage/cli #3350

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: update usage/cli #3350

wants to merge 5 commits into from

Conversation

JacobCoffee
Copy link
Member

Description

Closes

@JacobCoffee JacobCoffee requested review from a team as code owners April 9, 2024 03:51
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small type/docs pr/internal labels Apr 9, 2024
2. An :term:`object` named ``application`` that is an instance of :class:`Litestar <.app.Litestar>`
3. Any :term:`object` that is an instance of :class:`Litestar <.app.Litestar>`
4. A :term:`callable` named ``create_app``
5. A :term:`callable` annotated to return an instance of :class:`Litestar <.app.Litestar>`

Commands
--------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay hear me out - We have some unique things in here but with a big note to maintainability and scalability, they are not terribly useful compared to what the Click directive gives use (see https://docs.litestar.dev/latest/reference/cli.html)

@litestar-org/maintainers wdyt about removing this and just moving the reference of the commands up some.

My only concern is things like https://docs.litestar.dev/latest/usage/cli.html#ssl.

I was thinking we could enhance the help= for those commands but that file would become garagantuan.. I'm not sure of a better way. We could have a few sections I guess for special things like this - but I feel like they would become stale without us seeing it. The "Help" for those seems already good enough.. e.g., litestar run --help -> look at what the subcommands are.

Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too coupled with this massive ass table.

We could move it to a csv or similar sphinx table structure but I don't think it solves my concerns.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No pressure on just keeping it, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for better maintainability and a gargantuan cli file. We could also move the help strings for commands to another module as constants and import them into the cli module, if that would help alleviate.

2. An :term:`object` named ``application`` that is an instance of :class:`Litestar <.app.Litestar>`
3. Any :term:`object` that is an instance of :class:`Litestar <.app.Litestar>`
4. A :term:`callable` named ``create_app``
5. A :term:`callable` annotated to return an instance of :class:`Litestar <.app.Litestar>`

Commands
--------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for better maintainability and a gargantuan cli file. We could also move the help strings for commands to another module as constants and import them into the cli module, if that would help alleviate.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented May 8, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/internal size: small type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants