-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update usage/cli
#3350
base: main
Are you sure you want to change the base?
docs: update usage/cli
#3350
Conversation
docs/usage/cli.rst
Outdated
2. An :term:`object` named ``application`` that is an instance of :class:`Litestar <.app.Litestar>` | ||
3. Any :term:`object` that is an instance of :class:`Litestar <.app.Litestar>` | ||
4. A :term:`callable` named ``create_app`` | ||
5. A :term:`callable` annotated to return an instance of :class:`Litestar <.app.Litestar>` | ||
|
||
Commands | ||
-------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay hear me out - We have some unique things in here but with a big note to maintainability and scalability, they are not terribly useful compared to what the Click directive gives use (see https://docs.litestar.dev/latest/reference/cli.html)
@litestar-org/maintainers wdyt about removing this and just moving the reference of the commands up some.
My only concern is things like https://docs.litestar.dev/latest/usage/cli.html#ssl.
I was thinking we could enhance the help=
for those commands but that file would become garagantuan.. I'm not sure of a better way. We could have a few sections I guess for special things like this - but I feel like they would become stale without us seeing it. The "Help" for those seems already good enough.. e.g., litestar run --help
-> look at what the subcommands are.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too coupled with this massive ass table.
We could move it to a csv or similar sphinx table structure but I don't think it solves my concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No pressure on just keeping it, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote for better maintainability and a gargantuan cli file. We could also move the help strings for commands to another module as constants and import them into the cli module, if that would help alleviate.
docs/usage/cli.rst
Outdated
2. An :term:`object` named ``application`` that is an instance of :class:`Litestar <.app.Litestar>` | ||
3. Any :term:`object` that is an instance of :class:`Litestar <.app.Litestar>` | ||
4. A :term:`callable` named ``create_app`` | ||
5. A :term:`callable` annotated to return an instance of :class:`Litestar <.app.Litestar>` | ||
|
||
Commands | ||
-------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote for better maintainability and a gargantuan cli file. We could also move the help strings for commands to another module as constants and import them into the cli module, if that would help alleviate.
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3350 |
Description
usage/cli
docs as part of docs: update links, formatting, grammar, and remove contractions #3212 workCloses