feat: Add support for v2 model_dump and v1 dict to pydantic plugin #3327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 323 323
Lines 14777 14785 +8
Branches 2347 2345 -2
=======================================
+ Hits 14523 14531 +8
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
kedod
force-pushed
the
3147-add-support-all-kwargs-for-model-dump-in-pydantic-plugin
branch
from
2c86e28
to
8046b36
Compare
kedod
force-pushed
the
3147-add-support-all-kwargs-for-model-dump-in-pydantic-plugin
branch
from
8046b36
to
ca9b618
Compare
tests/e2e/test_pydantic.py
Outdated
There was a problem hiding this comment.
I think the tests should probably go into tests/test_contrib/test_pydantic/test_plugin_serialization.py.
There was a problem hiding this comment.
I'm not sure about it.
We still need E2E for checking the passing arguments flow.
Will be ok for you if E2E will stay here and I add additional tests to test_plugin_serialization?
litestar/types/serialization.py
Outdated
| @@ -57,3 +62,5 @@ | |||
| EncodableMsgSpecType: TypeAlias = "Ext | Raw | Struct" | |||
| LitestarEncodableType: TypeAlias = "EncodableBuiltinType | EncodableBuiltinCollectionType | EncodableStdLibType | EncodableStdLibIPType | EncodableMsgSpecType | BaseModel | AttrsInstance" # pyright: ignore | |||
| DataContainerType: TypeAlias = "Struct | BaseModel | AttrsInstance | TypedDictClass | DataclassProtocol" # pyright: ignore | |||
| PydanticV2FieldsListType: TypeAlias = "Set[int] | Set[str] | Dict[int, Any] | Dict[str, Any] | None" | |||
There was a problem hiding this comment.
just for my understanding, is it ok to have | None in the type alias? I would prefer PydanticV2FieldsListType | None just to be explicit, but I am not sure if that is the norm 🙂
There was a problem hiding this comment.
There is None in different type already:
EncodableBuiltinType: TypeAlias = "None | bool | int | float | str | bytes | bytearray"
But I like your approach more :)
Changed.
…n-pydantic-plugin
github-actions
bot
added
size: small
type/feat
area/types
…n-pydantic-plugin
…n-pydantic-plugin
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3327 |
Description
This is a continuation of #3171
The last unresolved conversation is here #3171 (comment)
Closes #3147