-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-16825 :: RawSqlStatement refactoring #5812
Conversation
…izedSqlStatement.
- Replacement of string concatenation by StringBuilder.
liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Fixed
Show fixed
Hide fixed
liquibase-integration-tests/src/test/java/liquibase/dbtest/AbstractIntegrationTest.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/database/core/DatabaseUtils.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/database/core/SQLiteDatabase.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/sqlgenerator/core/RawParameterizedSqlGenerator.java
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/sqlgenerator/core/RawSqlGenerator.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/test/java/liquibase/statement/core/RawSqStatementTest.java
Outdated
Show resolved
Hide resolved
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
liquibase-standard/src/main/java/liquibase/snapshot/jvm/ColumnSnapshotGenerator.java
Outdated
Show resolved
Hide resolved
# Conflicts: # liquibase-integration-tests/src/test/java/liquibase/dbtest/h2/H2IntegrationTest.java # liquibase-standard/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGenerator.java
…parameters. - Update test changeset that was causing some integration tests to fail.
# Conflicts: # liquibase-snowflake/src/main/java/liquibase/snapshot/jvm/UniqueConstraintSnapshotGeneratorSnowflake.java
Impact
Description
This PR is to address the initiative proposed in DAT-16825 to replace
RawSqlStatement
withRawParameterizedSqlStatement
.Also, since there were some of these changes already created for PR #5546 (Fix sonar scan
High
issues), I applied these changes starting from that PR. If you agree we can close that one.Things to be aware of
Things to worry about
Additional Context