html: support dark scheme #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on an MPTCP version of "flakes", the Dark Reader extension I used with my browser was poorly rendering the page when used from a local server. I realised it was easy to add a dark scheme support by overriding some colours in a '@media (prefers-color-scheme: dark)' section, in the CSS. So it will used the dark scheme if the browser prefers a dark scheme. Note that a text written with the default 'blue' colour is hardly visible when a dark background is used. So I used the recommended '#809fff' colour instead, a bit lighter, still blue. It is used with and without the dark scheme. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
|
I tweaked the palette a little but I really like this, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an MPTCP version of "flakes", the Dark Reader extension I used with my browser was poorly rendering the pages when used from a local server.
I realised it was easy to add a dark scheme support by overriding some colours in a '@media (prefers-color-scheme: dark)' section, in the CSS. So it will used the dark scheme if the browser prefers a dark scheme.
So I duplicated the solution here, just in case you want to support it as well :)
(The Dark Reader extension works good when looking at pages from https://netdev.bots.linux.dev, it's only for those not using the extension and still liking a dark scheme.)
Note that a text written with the default
bluecolour is hardly visible when a dark background is used. So I used the recommended#809fffcolour instead, a bit lighter, still blue. It is used with and without the dark scheme.