Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make association element can be subclass of type that implements IEnu… #4352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make association element can be subclass of type that implements IEnu… #4352

wants to merge 1 commit into from

Conversation

Ethen-Wang
Copy link

Make association element can be subclass of type that implements IEnumerable<T>

@viceroypenguin
Copy link
Contributor

/azp run test-all

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sdanyliv
sdanyliv requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@sdanyliv sdanyliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression Unit test.

Without Unit Test this change will be lost when we switch to upcoming release, which has everything rewritten in this area.

@MaceWindu MaceWindu added this to the In-progress milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdanyliv sdanyliv sdanyliv requested changes

@igor-tkachev igor-tkachev Awaiting requested review from igor-tkachev igor-tkachev is a code owner

@MaceWindu MaceWindu Awaiting requested review from MaceWindu MaceWindu is a code owner

@viceroypenguin viceroypenguin Awaiting requested review from viceroypenguin viceroypenguin is a code owner

@jods4 jods4 Awaiting requested review from jods4 jods4 is a code owner

@Shane32 Shane32 Awaiting requested review from Shane32 Shane32 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
In-progress
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ethen-Wang @viceroypenguin @sdanyliv @MaceWindu