test: [M3-8105] - Clean up cy.intercept calls in resize-linode #10476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
jdamore-linode,
hkhalil-akamai and
cliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
AzureLatte
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
a team
jaalah-akamai
approved these changes
May 16, 2024
There was a problem hiding this comment.
Seeing one call to cy.intercept() that slipped through the cracks!
ln 40
cy.intercept(
'POST',
apiMatcher(`linode/instances/${linode.id}/resize`)
).as('linodeResize');(GitHub wouldn't let me comment on those specific lines for some reason 😅)
There was a problem hiding this comment.
I'll update this one, thank you!
| 'POST', | ||
| apiMatcher(`linode/instances/${linode.id}/resize`) | ||
| ).as('linodeResize'); | ||
| mockGetFeatureFlagClientstream().as('linodeResize'); |
There was a problem hiding this comment.
Suggested change
| mockGetFeatureFlagClientstream().as('linodeResize'); | |
| interceptLinodeResize().as('linodeResize'); |
(This also applies to the replacements later in the file)
Interestingly the tests still run and pass just fine -- it calls into question whether the intercepts are even really necessary in these tests!
There was a problem hiding this comment.
Looks like there are some copy-paste errors :(
I'll correct them!
There was a problem hiding this comment.
Haha we've all been there 😅
jdamore-linode
approved these changes
May 17, 2024
AzureLatte
added
Clean Up
and removed
Approved
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Clean up cy.intercept calls in resize-linode
Changes 🔄
List any change relevant to the reviewer.
How to test 🧪
We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:
As an Author I have considered 🤔
Check all that apply