test: [M3-7991] - Integration Test: Linode Create with Placement Group #10473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
added
the
e2e
abailly-akamai
requested review from
AzureLatte,
mjac0bs and
hana-linode
and removed request for
a team
abailly-akamai
changed the title
|
Coverage Report: ✅ |
mjac0bs
approved these changes
May 16, 2024
There was a problem hiding this comment.
- Confirmed that test coverage is covering the main aspects of the create linode with PG flow.
- Watched the test run in debug mode and confirmed it passed.
- Confirmed the CI test failure is unrelated but if you make any updates to this PR, you'll want to merge in the latest develop to avoid another failure.
- Approving because LGTM - left only minor suggestions.
packages/manager/cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts
Outdated
Show resolved
Hide resolved
jdamore-linode
approved these changes
May 20, 2024
There was a problem hiding this comment.
Nice work @abailly-akamai, the new test looks (and runs) great!
packages/manager/cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts
Show resolved
Hide resolved
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
PR to add an integration test to the Placement Group feature within Linode Create flow
The test covers the following:
Changes 🔄
create-linode-with-placement-groups.spec.tstestdata-test-iddata-test-idcontaining JSX element as a child (was showing as "Object Object")How to test 🧪
Verification steps
yarn cy:run -s "cypress/e2e/core/placementGroups/create-linode-with-placement-groups.spec.ts"As an Author I have considered 🤔
Check all that apply